fix(topo): gc leaks with time.Tick

time.Tick leaks the underlying ticker and should only be used in endless functions.

Signed-off-by: xjasonlyu <xjasonlyu@gmail.com>

internal/topo/rule/ruleState.go

@@ -17,15 +17,16 @@ package rule
 import (
 	"context"
 	"fmt"
+	"math"
+	"math/rand"
+	"sync"
+	"time"
+
 	"github.com/lf-edge/ekuiper/internal/conf"
 	"github.com/lf-edge/ekuiper/internal/topo"
 	"github.com/lf-edge/ekuiper/internal/topo/planner"
 	"github.com/lf-edge/ekuiper/pkg/api"
 	"github.com/lf-edge/ekuiper/pkg/infra"
-	"math"
-	"math/rand"
-	"sync"
-	"time"
 )
 
 type ActionSignal int
@@ -157,6 +158,8 @@ func (rs *RuleState) runTopo(ctx context.Context) {
 		var (
 			er error
 		)
+		ticker := time.NewTicker(time.Duration(d) * time.Millisecond)
+		defer ticker.Stop()
 		for {
 			select {
 			case e := <-tp.Open():
@@ -181,7 +184,7 @@ func (rs *RuleState) runTopo(ctx context.Context) {
 				}
 				// retry after delay
 				select {
-				case <-time.Tick(time.Duration(d) * time.Millisecond):
+				case <-ticker.C:
 					break
 				case <-ctx.Done():
 					conf.Log.Errorf("stop rule %s retry as cancelled", rs.RuleId)