enable range/if-return check (#1738)

Signed-off-by: yisaer <disxiaofei@163.com>

internal/io/file/file_source.go

@@ -230,10 +230,7 @@ func (fs *FileSource) parseFile(ctx api.StreamContext, file string, consumer cha
 			}
 		}
 	}()
-	if err := fs.publish(ctx, r, consumer, meta); err != nil {
-		return err
-	}
-	return nil
+	return fs.publish(ctx, r, consumer, meta)
 }
 
 func (fs *FileSource) publish(ctx api.StreamContext, file io.Reader, consumer chan<- api.SourceTuple, meta map[string]interface{}) error {

internal/server/server.go

@@ -231,14 +231,14 @@ func resetAllStreams() error {
 	Streams := allStreams["streams"]
 	Tables := allStreams["tables"]
 
-	for name, _ := range Streams {
+	for name := range Streams {
 		_, err2 := streamProcessor.DropStream(name, ast.TypeStream)
 		if err2 != nil {
 			logger.Warnf("streamProcessor DropStream %s error: %v", name, err2)
 			continue
 		}
 	}
-	for name, _ := range Tables {
+	for name := range Tables {
 		_, err2 := streamProcessor.DropStream(name, ast.TypeTable)
 		if err2 != nil {
 			logger.Warnf("streamProcessor DropTable %s error: %v", name, err2)

internal/topo/node/switch_node.go

@@ -85,7 +85,7 @@ func (n *SwitchNode) Exec(ctx api.StreamContext, errCh chan<- error) {
 	}
 	n.statManager = stats
 	n.ctx = ctx
-	for i, _ := range n.outputNodes {
+	for i := range n.outputNodes {
 		n.outputNodes[i].ctx = ctx
 	}
 	fv, afv := xsql.NewFunctionValuersForOp(ctx)

tools/check/revive.toml

@@ -11,10 +11,10 @@ warningCode = -1
 #[rule.error-strings]
 [rule.error-naming]
 #[rule.exported]
-#[rule.if-return]
+[rule.if-return]
 #[rule.var-naming]
 #[rule.package-comments]
-#[rule.range]
+[rule.range]
 #[rule.receiver-naming]
 #[rule.indent-error-flow]
 #[rule.superfluous-else]